Adds hardhat-deploy scripts for proxy contracts #4
Conversation
acenolaza
force-pushed
the
proxy-deploy-scripts
branch
2 times, most recently
from
d992e9c to
a0a65c3
Compare
acenolaza
force-pushed
the
proxy-deploy-scripts
branch
2 times, most recently
from
c3c7e24 to
20c1c6c
Compare
acenolaza
force-pushed
the
proxy-deploy-scripts
branch
from
20c1c6c to
f9a155d
Compare
acenolaza
force-pushed
the
proxy-deploy-scripts
branch
from
7e85928 to
8bb04bb
Compare
acenolaza
force-pushed
the
proxy-deploy-scripts
branch
from
86fbafc to
abeb310
Compare
There was a problem hiding this comment.
We can omit this. The repo only needs the proxy combinators, similarly for the interface, deployment script and deployment JSON files.
|
|
||
| const isLocalNetwork = network.name === 'hardhat' || network.name === 'localhost'; | ||
|
|
||
| const confirmations = isLocalNetwork ? 1 : 5; |
There was a problem hiding this comment.
On some chains 5 confirmations might take quite a long time but on most it won't. This number was suggested to me by the hardhat-deploy plugin when deploying against ethereum-sepolia-testnet and usually 5 confirmations is a common safety measure for non-local deployments, balancing speed with protection against blockchain reorganizations.
There was a problem hiding this comment.
What is the purpose of this file? Imo we shouldn't store the deployment files (because arguably they are going to be deployed by third parties and having the deployments stored doesn't make sense for Api3).
There was a problem hiding this comment.
Because of Morpho I thought that we would be doing the deployments for them. I've remove everything to deployments and Morpho tho 👍🏻
No description provided.